Skip to content

test(precompiles): TIP-1022 virtual address and Recipient coverage#3432

Merged
0xrusowsky merged 3 commits intomainfrom
rusowsky/tip20-virtual-coverage
Apr 8, 2026
Merged

test(precompiles): TIP-1022 virtual address and Recipient coverage#3432
0xrusowsky merged 3 commits intomainfrom
rusowsky/tip20-virtual-coverage

Conversation

@decofe
Copy link
Copy Markdown
Member

@decofe decofe commented Apr 2, 2026

Unit tests for Recipient struct and AddressRegistry gaps from #3286.

  • Recipient unit tests: direct/resolve/validate/build_transfer_event/build_virtual_transfer_event, including pre-T3 literal passthrough
  • AddressRegistry tests: resolve_virtual_address (non-virtual/unregistered/registered), is_valid_master_address (zero/virtual/tip20/valid), resolve_recipient pre-T3 passthrough
  • Extended mint/transfer/transferFrom virtual tests to also cover memo variants (mintWithMemo, transferWithMemo, transferFromWithMemo)
  • Consolidated unregistered-virtual revert test to cover all 6 entrypoints (mint, mintWithMemo, transfer, transferWithMemo, transferFrom, transferFromWithMemo)

Co-Authored-By: 0xrusowsky 90208954+0xrusowsky@users.noreply.github.com

Prompted by: rusowsky

Adds Recipient unit tests (direct, resolve, validate, event builders),
AddressRegistry gap tests (resolve_virtual_address, is_valid_master_address,
resolve_recipient pre-T3), and extends existing virtual address tests to
cover memo variants and unregistered-address reverts for all entrypoints.

Co-Authored-By: 0xrusowsky <90208954+0xrusowsky@users.noreply.github.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d4d32-4300-71d9-8d91-632c2147c49d
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

📊 Tempo Precompiles Coverage

📦 Download full HTML report

decofe and others added 2 commits April 8, 2026 08:42
Reduces test LOC by ~220 lines while preserving full coverage:

- Consolidated 8 `recipient_tests` into 3 (resolve, validate,
build_events) — added `#[derive(Debug, PartialEq)]` on `Recipient` for
structural asserts
- DRYed `WithMemo` coverage in mint/transfer/transferFrom virtual tests
— extract `credited` address once, check balance delta instead of
repeating hardfork branches
- Compressed `test_unregistered_virtual_reverts_on_t3` from 80 lines to
6 one-liner asserts

Prompted by: rusowsky

Co-Authored-By: 0xrusowsky
<90208954+0xrusowsky@users.noreply.github.com>
@0xrusowsky 0xrusowsky marked this pull request as ready for review April 8, 2026 07:00
@0xrusowsky 0xrusowsky added this pull request to the merge queue Apr 8, 2026
Merged via the queue into main with commit c3fae75 Apr 8, 2026
33 checks passed
@0xrusowsky 0xrusowsky deleted the rusowsky/tip20-virtual-coverage branch April 8, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants